Implement pitch detection in tuner frequency method#5302
Open
7se7en72025 wants to merge 1 commit intosugarlabs:masterfrom
Open
Implement pitch detection in tuner frequency method#53027se7en72025 wants to merge 1 commit intosugarlabs:masterfrom
7se7en72025 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Replaces the placeholder in getTunerFrequency with actual pitch detection using the YIN algorithm. Stores analyser and pitch detection function as instance properties for reuse and reliability.
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
note: I didn't bother changing any of the UI, so it’ll look the same, but the logic is actually there. |
Contributor
Author
|
@walterbender any ideas why my PR's get lint issues even i run prttier ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the placeholder in getTunerFrequency with actual pitch detection using the YIN algorithm. Stores analyser and pitch detection function as instance properties for reuse and reliability.it was hardcoded to 440hz . it works now.